Hi Kinsey,
In reviewing the latest versions, I do not see any changes based on the suggestions we provided. For your reference, here are the list of proposed edits (these were based on version 5 so the line numbers may not be accurate):
- Line 4 . It is a best practice to not use Close All so that data is not lost by the user.
- Line 14. If the user answers "No", the script can be stopped after the Web call.
- Lines 41 to 61. Email addresses are being exposed. We recommend removing these.
- Line 244. The list stored in the mfi variable could be used rather than calling Get Data Table List().
- Line 255. The statement can be removed since dt0 already references the table.
- Line 479. The statement can be removed since dt1 already references the table.
- Line 484. Is the importSheet function necessary? If not, it can be removed.
- Line 817, 883, 997. We recommend avoiding the use of "current data table()" as the table can change if the user clicks another table while the script is running.
- Remove Show statements.
- Remove unused/commented code.
- Consider using more meaningful names for dtN variables, eg. dt1 could be dtGradingSpreadsheet. Overall, well done. You made excellent use of the Zip archive as well as multi-file import.
- For the article content, it would be helpful if you could provide further details on the purpose of the script, how to use it, screen shots, etc.
Also, it would be helpful if you could update the article started in the Scripts dashboard since that is more closely monitored.
Thanks.
Ryan