topic Re: [JSL Bug] Got problem when try to concatenate two tables from different directory in Discussions

[JSL Bug] Got problem when try to concatenate two tables from different directory

achid03 — Fri, 09 Jun 2023 19:51:29 GMT

Hi All,

I'm a new user in JMP scripting and need help to find bugs in my code.

What I'm trying to do here is to concatenate already opened data files (dt1 and dt2). I found that the script did not concatenate the two tables. line 41 and so on was not executed plus with no error message

Can anyone help me with it?

Thanks

Re: [JSL Bug] Got problem when try to concatenate two tables from different directory

jthi — Fri, 02 Jul 2021 11:01:15 GMT

I think you will have to reassign dt1 and dt2 to open command after Pick File as Pick File will return path to the picked file.

Names Default To Here(1);
dt1 = Pick File(
	"Select JMP File",
	"$DOCUMENTS",
	{"JMP Files|jmp;jsl;jrn", "All Files|*"},
	1,
	0,
	"newJmpFile.jmp"
);
dt1 = Open(dt1);

Re: [JSL Bug] Got problem when try to concatenate two tables from different directory

achid03 — Sat, 03 Jul 2021 07:51:06 GMT

I did reassign dt1 and dt2. But it didn't work

Re: [JSL Bug] Got problem when try to concatenate two tables from different directory

jthi — Sat, 03 Jul 2021 08:27:30 GMT

This works fine:

Names Default To Here(1);
dt1_dir = Pick Directory("Pick dir", "$SAMPLE_DATA/");
dt1 = Pick File(
	"Select JMP File",
	dt1_dir,
	{"JMP Files|jmp;jsl;jrn", "All Files|*"},
	1,
	0,
	0
);
Show(dt1);
dt1 = Open(dt1);
Show(dt1);

dt2_dir = Pick Directory("Pick dir", "$SAMPLE_DATA/");
dt2 = Pick File(
	"Select JMP File",
	dt2_dir,
	{"JMP Files|jmp;jsl;jrn", "All Files|*"},
	1,
	0,
	0
);
Show(dt2);
dt2 = Open(dt2);
Show(dt2);

concat_dt = dt1 << Concatenate(dt2,
	Output Table("Concat datatable"),
	Create Source Column
);

Do similar changes to your code and check if it works (check Concatenate())

Re: [JSL Bug] Got problem when try to concatenate two tables from different directory

achid03 — Sat, 03 Jul 2021 09:42:18 GMT

yeah it works! and why you put "show" two times?

Re: [JSL Bug] Got problem when try to concatenate two tables from different directory

Craige_Hales — Sat, 03 Jul 2021 10:18:19 GMT

Look in the log and you'll see the show before the assignment is a string, and after the assignment is a data table.

Re: [JSL Bug] Got problem when try to concatenate two tables from different directory

Craige_Hales — Sat, 03 Jul 2021 10:32:57 GMT

...normally I'd name these variables differently:

dt1Name = "c:\...data.jmp";
dt1 = open(dt1Name);

so the name better describes the contents of the variable. Sometimes I reuse variables, but it usually causes me to make mistakes.