topic Re: Optimize "for each row" in Discussions

Optimize "for each row"

tom_abramov — Tue, 07 Jan 2020 13:56:03 GMT

Hello,

I have this script on the Big Class table.

On large tables, it takes too much time.

Is there some other quicker way?

AgesList = {13,14};
for each row(dt, if(Contains(AgesList ,dt:Name("Age"))>0,dt:Name("height")=-1));

Thanks.

Re: Optimize "for each row"

Mark_Bailey — Tue, 07 Jan 2020 12:33:10 GMT

There are a few unnecessary elements in your script. I do not know if they would add that much time, though. Here is a stripped-down, cleaner version:

Names Default To Here( 1 );

dt = Open( "$SAMPLE_DATA/Big Class.jmp" );

AgesList = {13, 14};

For Each Row(
	If( Contains( AgesList, dt:age ),
		dt:height = -1;
	);
);

Re: Optimize "for each row"

pmroz — Tue, 07 Jan 2020 13:58:55 GMT

This might be faster

Names Default To Here( 1 );
dt = Open( "$SAMPLE_DATA/Big Class.jmp" );
AgesList = {13, 14};
ages_rows = dt << get rows where(contains(ageslist, dt:age));
dt:height[ages_rows] = -1;